> On Aug. 26, 2013, 6:37 a.m., Kevin Ottens wrote: > > staging/kguiaddons/src/util/kiconutils.h, line 31 > > <http://git.reviewboard.kde.org/r/112079/diff/2/?file=184119#file184119line31> > > > > Not sure about the use of "draw" here. Those methods don't draw, right? > > > > "Adds" sounds better to me.
They do, they call "painter->drawPixmap(overlayIcon)" after all. I'd like to keep "draw" so it's clear it really does "draw". > On Aug. 26, 2013, 6:37 a.m., Kevin Ottens wrote: > > staging/kguiaddons/src/util/kiconutils.h, line 48 > > <http://git.reviewboard.kde.org/r/112079/diff/2/?file=184119#file184119line48> > > > > I tend to agree with Nicolas on the plural for naming that one. Ok > On Aug. 26, 2013, 6:37 a.m., Kevin Ottens wrote: > > staging/kguiaddons/src/util/kiconutils.cpp, line 30 > > <http://git.reviewboard.kde.org/r/112079/diff/2/?file=184120#file184120line30> > > > > Hmmm, why did you ignore all the Q_DECL_OVERRIDE comments for that > > class? Little misunderstanding, will fix. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38570 ----------------------------------------------------------- On Aug. 23, 2013, 9:25 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112079/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2013, 9:25 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > As this was rejected from QIcon, I decided to implement it in frameworks. The > idea is new private icon engine (KOverlayIconEngine), which paints the > overlays itself, and then an utility function in KIconUtils:: namespace, > which takes the base icon and the overlay icons as parameters and constructs > new QIcon using KOverlayIconEngine. As QPixmapIconEngine (QIcon default) is > private in Qt and couldn't be simply extended, the KOverlayIconEngine simply > forwards the calls to QIcon, which then forwards those calls internally to > QPixmapIconEngine (QIcon is really mostly just a wrapper around an engine). > > There are two functions > > QIcon KIconUtils::kIconAddOverlay(const QIcon &icon, const QIcon &overlay, > Qt::Corner position); > > and > > QIcon KIconUtils::kIconAddOverlay(const QIcon &icon, QHash<Qt::Corner, QIcon> > overlays); > > The first one serves for single overlay icon, the second one is then for > multiple overlays, requires the QHash to be built up before passing though. > > > Diffs > ----- > > staging/kguiaddons/src/CMakeLists.txt fc8941a > staging/kguiaddons/src/util/kiconutils.h PRE-CREATION > staging/kguiaddons/src/util/kiconutils.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112079/diff/ > > > Testing > ------- > > I have a small testing app with 3 QLabels, testing both ::paint() and > ::pixmap() methods, all works \o/ I'm thinking about bundling the app with > kguiaddons and/or additionally creating a unittest for it (I have one for Qt > already), but I'll do that later as I'm off to vacation and I'd like to get > comments for the code. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
