----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36960 -----------------------------------------------------------
staging/kservice/tools/desktoptojson/kconfigtojson.h <http://git.reviewboard.kde.org/r/111689/#comment27263> I don't like file-static QStrings (global objects), and even less in headers (it creates an unused variable in any user of the header). My suggestion: define the command-line options in the KConfigToJson constructor or runMain(). To go even further and avoid the need for shared strings completely: store the two QCommandLineOptions as members of the class, and pass them to isSet() and value(), instead of strings. staging/kservice/tools/desktoptojson/kconfigtojson.cpp <http://git.reviewboard.kde.org/r/111689/#comment27266> ;; -> ; staging/kservice/tools/desktoptojson/kconfigtojson.cpp <http://git.reviewboard.kde.org/r/111689/#comment27265> ;; -> ; staging/kservice/tools/desktoptojson/main.cpp <http://git.reviewboard.kde.org/r/111689/#comment27264> It makes no difference in this particular case, but it's always better to create the app first, and then use any other Qt API => swap the first two lines. - David Faure On Aug. 1, 2013, 6:59 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111689/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 6:59 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Small program which takes a .desktop file and converts it to json. This is > useful to convert plugins which have their metadata in .desktop files (i.e. > all KDE plugins) to Qt's new plugin system. > > > Diffs > ----- > > staging/kservice/tools/CMakeLists.txt PRE-CREATION > staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION > staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION > staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION > staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111689/diff/ > > > Testing > ------- > > Converted metadata of several plugins and used them from QPluginLoader -- > works. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
