----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36959 -----------------------------------------------------------
staging/kservice/tools/CMakeLists.txt <http://git.reviewboard.kde.org/r/111689/#comment27260> Should be under src staging/kservice/tools/desktoptojson/kconfigtojson.h <http://git.reviewboard.kde.org/r/111689/#comment27261> Why those default parameters? The implementation code actually doesn't seem ready to be called with no parameters, and is never called that way. You probably want to drop the default values here. staging/kservice/tools/desktoptojson/main.cpp <http://git.reviewboard.kde.org/r/111689/#comment27262> Why 2.0 and not 1.0? :-) - Kevin Ottens On Aug. 1, 2013, 6:59 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111689/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 6:59 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Small program which takes a .desktop file and converts it to json. This is > useful to convert plugins which have their metadata in .desktop files (i.e. > all KDE plugins) to Qt's new plugin system. > > > Diffs > ----- > > staging/kservice/tools/CMakeLists.txt PRE-CREATION > staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION > staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION > staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION > staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111689/diff/ > > > Testing > ------- > > Converted metadata of several plugins and used them from QPluginLoader -- > works. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
