----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36463 -----------------------------------------------------------
Nice. Now that we have an all new file, we can make it really pretty and try to follow the cmake guidelines as close as possible. So here we go * please use ExactCase variable names, e.g. DBusMenuQt5_LIBRARIES instead of DBUSMENUQT5_LIBRARIES * also for the _FOUND variable. This is set by find_package_handle_standard_args() automatically. Use the option find_package_handle_standard_args( ... FOUND_VAR DBusMenuQt5_FOUND ...) to make it set the DBusMenuQt5_FOUND instead of DBUSMENUQT5_FOUND * when searching for the library, please search for DBusMenuQt5_LIBRARY (singular), and put that then into DBusMenuQt5_LIBRARIES. The _LIBRARY variable is the one which goes into the cache, and which can potentially be edited by the user. As interface of the Find-module PackageName_LIBRARIES should be used. Potentially the library found by a Find-module may need multiple libraries to be linked, that's why the plural form. And that's why the singular forms should go into the cache. * The same for the include dirs. The find_path() call is good, and then put the result into DBusMenuQt5_INCLUDE_DIRS (plural). Also document the plural forms at the top (decide for yourself whether you also want to document the singular form variables). * for mark_as_advanced() and find_package_handle_standard_args() the singular forms are the ones to use. Thanks Alex - Alexander Neundorf On July 24, 2013, 7:26 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111649/ > ----------------------------------------------------------- > > (Updated July 24, 2013, 7:26 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file > > > Diffs > ----- > > CMakeLists.txt c2f3cfcc84553a89992ff7cdd56bb3cf7a319661 > cmake/modules/FindDBusMenuQt.cmake c231aeac0fe118577fbd57e83320f59c6e6cc23d > cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION > kdeui/CMakeLists.txt 6295988bc42fc91eb7e27f737dd7dcadf6ae14c8 > staging/knotifications/src/CMakeLists.txt > cfaa38a88e20f8a87b0dbd13217521bc46dfa993 > > Diff: http://git.reviewboard.kde.org/r/111649/diff/ > > > Testing > ------- > > kdelibs no longer links to system dbusmenu-qt > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
