----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111408/#review36038 -----------------------------------------------------------
Ship it! Small qDebug nitpick, please fix it and push. kdeui/dialogs/kconfigdialogmanager.cpp <http://git.reviewboard.kde.org/r/111408/#comment26683> Put this one as a comment please - Kevin Ottens On July 16, 2013, 10:23 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111408/ > ----------------------------------------------------------- > > (Updated July 16, 2013, 10:23 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Moved the class, only small changes: > - kDebug -> qDebug > - Added ugly defines so that we don't have to add constructors to QString > and casts from QByteArray -> const char* > > > Diffs > ----- > > kdeui/CMakeLists.txt 35b4019 > kdeui/dialogs/kconfigdialogmanager.h ddac3eb > kdeui/dialogs/kconfigdialogmanager.cpp 7e8e73f > staging/kconfigwidgets/CMakeLists.txt e71eeb5 > staging/kconfigwidgets/src/CMakeLists.txt 3433e10 > > Diff: http://git.reviewboard.kde.org/r/111408/diff/ > > > Testing > ------- > > Builds > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
