> On July 8, 2013, 10:42 a.m., Kevin Ottens wrote: > > kdeui/dialogs/kconfigdialogmanager.cpp, line 22 > > <http://git.reviewboard.kde.org/r/111408/diff/1/?file=169157#file169157line22> > > > > Likely better to either fix the issues or do that from the > > CMakeLists.txt with remove_definitions.
if I do it with removed_definitions it will apply to the other files as well... "fixing" the issues adds a huge noise in the source code for little reason, IMHO. But I can make it compile if that's what's supposed to be done. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111408/#review35723 ----------------------------------------------------------- On July 5, 2013, 5:16 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111408/ > ----------------------------------------------------------- > > (Updated July 5, 2013, 5:16 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Moved the class, only small changes: > - kDebug -> qDebug > - Added ugly defines so that we don't have to add constructors to QString > and casts from QByteArray -> const char* > > > Diffs > ----- > > kdeui/CMakeLists.txt c7dd8c2 > kdeui/dialogs/kconfigdialogmanager.h ddac3eb > kdeui/dialogs/kconfigdialogmanager.cpp 7e8e73f > staging/kconfigwidgets/src/CMakeLists.txt cd0afd2 > > Diff: http://git.reviewboard.kde.org/r/111408/diff/ > > > Testing > ------- > > Builds > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
