----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111183/#review35468 -----------------------------------------------------------
kdeui/widgets/klanguagebutton.h <http://git.reviewboard.kde.org/r/111183/#comment26005> The docu needs adjusting. The default is now QLocale::system().name(). kdeui/widgets/klanguagebutton.cpp <http://git.reviewboard.kde.org/r/111183/#comment26006> (while you're making changes there, adapt to kdelibs coding style: setLocale(const QString &locale) ) kdeui/widgets/klanguagebutton.cpp <http://git.reviewboard.kde.org/r/111183/#comment26007> Isn't that the same as setCurrentItem(d->locale) ? - David Faure On July 2, 2013, 4:44 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111183/ > ----------------------------------------------------------- > > (Updated July 2, 2013, 4:44 p.m.) > > > Review request for KDE Frameworks and Kevin Ottens. > > > Description > ------- > > * Move KLanguageButton to KWidgets > * Ported to QLocale > > > Diffs > ----- > > staging/kwidgets/src/CMakeLists.txt e337b81 > kdeui/widgets/klanguagebutton.cpp c5d8e4b > kdeui/widgets/klanguagebutton.h feb2b5b > kdeui/CMakeLists.txt d8b9b53 > > Diff: http://git.reviewboard.kde.org/r/111183/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
