----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111183/#review35452 -----------------------------------------------------------
I don't understand the description of the change. It says "KLocale code is commented", but I don't see KLocal* anywhere. All I see is an apparently unused klocalizedstring.h include? - David Faure On July 2, 2013, 9:07 a.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111183/ > ----------------------------------------------------------- > > (Updated July 2, 2013, 9:07 a.m.) > > > Review request for KDE Frameworks and Kevin Ottens. > > > Description > ------- > > The KLocate code is commented. I don't know if this is OK, or if I've to port > it to QLocale first and then it can be moved to kwidgets. > > This patch must be applied with the others 2 that I'm going to push later. > KHelpMenu uses KLanguageButton through KSwitchLanguageDialogPrivate. > > > Diffs > ----- > > kdeui/CMakeLists.txt abc7a2d > kdeui/widgets/klanguagebutton.h feb2b5b > kdeui/widgets/klanguagebutton.cpp c5d8e4b > staging/kwidgets/src/CMakeLists.txt e337b81 > staging/kwidgets/src/widgets/klanguagebutton.h PRE-CREATION > staging/kwidgets/src/widgets/klanguagebutton.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111183/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
