----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/#review33367 -----------------------------------------------------------
the description is slightly wrong now: the test doesn't need kde4support anymore. staging/knotifications/src/kstatusnotifieritem.cpp <http://git.reviewboard.kde.org/r/110482/#comment24679> unused (fortunately) staging/knotifications/src/kstatusnotifieritem.cpp <http://git.reviewboard.kde.org/r/110482/#comment24678> doesn't look portable to Windows? staging/knotifications/src/kstatusnotifieritem.cpp <http://git.reviewboard.kde.org/r/110482/#comment24677> static objects are bad... this should be a static const char[], actually. staging/knotifications/src/kstatusnotifieritemdbus_p.cpp <http://git.reviewboard.kde.org/r/110482/#comment24680> unused staging/knotifications/tests/kstatusnotifieritemtest.cpp <http://git.reviewboard.kde.org/r/110482/#comment24675> Strange include. The prefix kdeqt5staging/ shouldn't be necessary. staging/knotifications/tests/kstatusnotifieritemtest.cpp <http://git.reviewboard.kde.org/r/110482/#comment24676> -> QDebug - David Faure On May 28, 2013, 7:11 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110482/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 7:11 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > This implemets a step in the kdeui crumble epic. > > moves the classes kstatusnotifieritem and knotificationsrestrictions in the > knotifiactions library. > > The patch works, but there are still several issues: > * porting from kdebug to qdebug loses the area number > * adds some link libraries: the classes add ki18n, kwidgets and KWidgetsAddons > * the test adds ki18n kde4support kdecore > * the KActionCollection becomes a qhash of actions: how should be > kactioncollections ported? > > I guess it should use the qt translation system, and redo the quit dialog to > not usekstandardgui at all? > > > Diffs > ----- > > kdeui/CMakeLists.txt cfa29ef > kdeui/notifications/knotificationrestrictions.h 7b83d25 > kdeui/notifications/knotificationrestrictions.cpp a396fd6 > kdeui/notifications/kstatusnotifieritem.h be21882 > kdeui/notifications/kstatusnotifieritem.cpp 37abe7e > kdeui/notifications/kstatusnotifieritemdbus_p.h 063343c > kdeui/notifications/kstatusnotifieritemdbus_p.cpp 6c9e1da > kdeui/notifications/kstatusnotifieritemprivate_p.h 32e7906 > kdeui/notifications/org.freedesktop.Notifications.xml 8ddb421 > kdeui/notifications/org.kde.StatusNotifierItem.xml 82c427d > kdeui/notifications/org.kde.StatusNotifierWatcher.xml dd45dc9 > kdeui/tests/CMakeLists.txt cd055d5 > kdeui/tests/kstatusnotifieritemtest.h 38a1e1a > kdeui/tests/kstatusnotifieritemtest.cpp 38e85ac > staging/knotifications/src/CMakeLists.txt 266b67c > staging/knotifications/src/knotificationrestrictions.h PRE-CREATION > staging/knotifications/src/knotificationrestrictions.cpp PRE-CREATION > staging/knotifications/src/kstatusnotifieritem.h PRE-CREATION > staging/knotifications/src/kstatusnotifieritem.cpp PRE-CREATION > staging/knotifications/src/kstatusnotifieritemdbus_p.h PRE-CREATION > staging/knotifications/src/kstatusnotifieritemdbus_p.cpp PRE-CREATION > staging/knotifications/src/kstatusnotifieritemprivate_p.h PRE-CREATION > staging/knotifications/src/org.freedesktop.Notifications.xml PRE-CREATION > staging/knotifications/src/org.kde.StatusNotifierItem.xml PRE-CREATION > staging/knotifications/src/org.kde.StatusNotifierWatcher.xml PRE-CREATION > staging/knotifications/tests/CMakeLists.txt 2240a69 > staging/knotifications/tests/kstatusnotifieritemtest.h PRE-CREATION > staging/knotifications/tests/kstatusnotifieritemtest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110482/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
