> On May 21, 2013, 10:46 a.m., Kevin Ottens wrote:
> > I think it's taking the right direction. Probably good to get rid of ki18n 
> > if we don't use any of its advanced features (I don't think we do). As for 
> > kwidgets and kwidgetsaddons, it depends a bit on the aim we have for that 
> > library and which tier we want for it. If we aim tier1 it can't depend on 
> > them, if we aim tier2 it can depend on kwidgetsaddons, if we aim tier3 it 
> > can depend on both.
> > 
> > Any idea why it requires KWidgets and KWidgetsAddons?
> > 
> > Test should be streamlined to bring less dependencies too.
> 
> Marco Martin wrote:
>     i think kwidgets and kwidgetsaddons are required by the "are sure you 
> want to quit" dialog, shar should be rebuilt using only basic qt stuff.
>     
>     another source of dependencies is the small test app, that uses 
> kcmdlineargs and kiconloader for "findMovie"

ah, in general, what should replace KActionCollections?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110482/#review32879
-----------------------------------------------------------


On May 18, 2013, 3:27 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110482/
> -----------------------------------------------------------
> 
> (Updated May 18, 2013, 3:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This implemets a step in the kdeui crumble epic.
> 
> moves the classes kstatusnotifieritem and knotificationsrestrictions in the 
> knotifiactions library.
> 
> The patch works, but there are still several issues:
> * porting from kdebug to qdebug loses the area number
> * adds some link libraries: the classes add ki18n, kwidgets and KWidgetsAddons
> * the test adds ki18n kde4support kdecore
> * the KActionCollection becomes a qhash of actions: how should be 
> kactioncollections ported?
> 
> I guess it should use the qt translation system, and redo the quit dialog to 
> not usekstandardgui at all?
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt cfa29ef 
>   kdeui/tests/CMakeLists.txt cd055d5 
>   staging/knotifications/src/CMakeLists.txt 266b67c 
>   staging/knotifications/src/knotificationrestrictions.cpp a396fd6 
>   staging/knotifications/src/kstatusnotifieritem.h be21882 
>   staging/knotifications/src/kstatusnotifieritem.cpp 37abe7e 
>   staging/knotifications/src/kstatusnotifieritemdbus_p.cpp 6c9e1da 
>   staging/knotifications/src/kstatusnotifieritemprivate_p.h 32e7906 
>   staging/knotifications/tests/CMakeLists.txt 2240a69 
>   staging/knotifications/tests/kstatusnotifieritemtest.cpp 38e85ac 
> 
> Diff: http://git.reviewboard.kde.org/r/110482/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to