> On March 16, 2013, 3:39 p.m., Albert Astals Cid wrote: > > What about all the features KListWidget has and QListWidget hasn't? Are we > > ok with that? Or are we porting all the KListWidgets features to > > QListWidget? > > Kevin Ottens wrote: > Can you point to a feature which would be lost or is that rhethorical? > > Albert Astals Cid wrote: > I just assumed that noone wrote 300 lines of code for nothing. > > What about the autoselect timer thing for example? > > David Faure wrote: > Autoselect (which is a way to make single-click-mode more usable for some > users) seems to be missing from QAbstractItemView indeed. > > This is definitely not enough to be worth a subclass though. It should > either be implemented in QAbstractItemView itself, or (worse solution), it > could be implemented in KDE code using an event filter watching the view.
TODO added to http://community.kde.org/Frameworks/Epics/Qt_5.1_Merging - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109517/#review29317 ----------------------------------------------------------- On March 16, 2013, 11:30 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109517/ > ----------------------------------------------------------- > > (Updated March 16, 2013, 11:30 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Move KListWidget to kde4support and replace uses with QListWidget > > > Diffs > ----- > > kdeui/CMakeLists.txt 03b1e8d > kdeui/dialogs/kinputdialog.cpp 28ce074 > kdeui/dialogs/kinputdialog_p.h 9b40158 > kdeui/fonts/kfontchooser.cpp a445f43 > kdeui/icons/kicondialog.cpp aeba58c > kdeui/icons/kicondialog_p.h bc46295 > kdeui/itemviews/klistwidget.h 48ef4d7 > kdeui/itemviews/klistwidget.cpp 185db8b > kdeui/widgets/kcompletionbox.h 1dabb1a > kdeui/widgets/kcompletionbox.cpp a470621 > khtml/rendering/render_form.h 28c3082 > khtml/rendering/render_form.cpp 851a4dd > staging/kde4support/src/CMakeLists.txt 0543844 > > Diff: http://git.reviewboard.kde.org/r/109517/diff/ > > > Testing > ------- > > Compiles > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel