> On March 16, 2013, 5:46 p.m., Albert Astals Cid wrote:
> > we are using the executed signal in some of the classes that is gone when 
> > you move to qlistwidget

executed() is called itemActivated() in Qt. The point of that signal is that 
it's emitted on single click, in single-click mode, and on a double-click, in 
double-click mode. Qt supports this these days, with the styleHint 
QStyle::SH_ItemView_ActivateItemOnSingleClick (which KDE styles set correctly 
from the user's settings).

So this requires a bit of porting, but no functionality is lost.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109517/#review29326
-----------------------------------------------------------


On March 16, 2013, 11:30 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109517/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 11:30 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move KListWidget to kde4support and replace uses with QListWidget
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 03b1e8d 
>   kdeui/dialogs/kinputdialog.cpp 28ce074 
>   kdeui/dialogs/kinputdialog_p.h 9b40158 
>   kdeui/fonts/kfontchooser.cpp a445f43 
>   kdeui/icons/kicondialog.cpp aeba58c 
>   kdeui/icons/kicondialog_p.h bc46295 
>   kdeui/itemviews/klistwidget.h 48ef4d7 
>   kdeui/itemviews/klistwidget.cpp 185db8b 
>   kdeui/widgets/kcompletionbox.h 1dabb1a 
>   kdeui/widgets/kcompletionbox.cpp a470621 
>   khtml/rendering/render_form.h 28c3082 
>   khtml/rendering/render_form.cpp 851a4dd 
>   staging/kde4support/src/CMakeLists.txt 0543844 
> 
> Diff: http://git.reviewboard.kde.org/r/109517/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to