----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108560/ -----------------------------------------------------------
(Updated Jan. 23, 2013, 6:14 p.m.) Review request for KDE Frameworks. Changes ------- removed formatting changes from the diff Description ------- Fix kconfigcompiler_test by porting to QFINDTESTDATA It previously did not find the required files since CMake set TESTSRCDIR wrongly. It was surrounded by quotes and lacking a trailing / This did not cause test failures since QCOMPARE/QVERIFY was not used directly in the test function, so it simply printed messages instead. Diffs (updated) ----- tier2/kconfig/autotests/kconfig_compiler/CMakeLists.txt 846476a6370ad41b1fbc808e2c738c85042e59a3 tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.h 1be213f5036c03a3ef9347005d5d53e6b440a4d4 tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp f900aaf53de1996213c27357fee5b436ab3c4c8f Diff: http://git.reviewboard.kde.org/r/108560/diff/ Testing ------- Unit test now passes instead of printing messages and failing silently Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
