----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108560/#review26082 -----------------------------------------------------------
tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp <http://git.reviewboard.kde.org/r/108560/#comment19853> Unrelated change. tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp <http://git.reviewboard.kde.org/r/108560/#comment19855> Unrelated change. tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp <http://git.reviewboard.kde.org/r/108560/#comment19856> Unrelated change. tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp <http://git.reviewboard.kde.org/r/108560/#comment19854> Unrelated change. tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp <http://git.reviewboard.kde.org/r/108560/#comment19857> Unrelated change. - Laszlo Papp On Jan. 22, 2013, 10:13 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108560/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 10:13 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Fix kconfigcompiler_test by porting to QFINDTESTDATA > > It previously did not find the required files since CMake set TESTSRCDIR > wrongly. It was surrounded by quotes and lacking a trailing / > > This did not cause test failures since QCOMPARE/QVERIFY was not used > directly in the test function, so it simply printed messages instead. > > > Diffs > ----- > > tier2/kconfig/autotests/kconfig_compiler/CMakeLists.txt > 846476a6370ad41b1fbc808e2c738c85042e59a3 > tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.h > 1be213f5036c03a3ef9347005d5d53e6b440a4d4 > tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp > f900aaf53de1996213c27357fee5b436ab3c4c8f > > Diff: http://git.reviewboard.kde.org/r/108560/diff/ > > > Testing > ------- > > Unit test now passes instead of printing messages and failing silently > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
