----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108449/#review25746 -----------------------------------------------------------
This is essentially a small subset of my review 108263. I see nothing wrong with it, but I think it is unnecessary as we could just push my more extensive patch directly instead. That said, I see no problem in rebasing my patch on top of this, so if you are uncomfortable with the size of my patch, feel free to push this one for the time being. - Jon Severinsson On Jan. 17, 2013, 4:27 p.m., Kevin Ottens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108449/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2013, 4:27 p.m.) > > > Review request for KDE Frameworks, David Faure, John Layt, and Jon > Severinsson. > > > Description > ------- > > Adjust to Julian Day computation in Qt5's QDate > > Qt5 uses a new algorithm for deal with julian days so adjust > KCalendarSystem to it. Because of that change, January 1st -4712 is not > a wednesday anymore but a saturday, so one of the cases for ISO Week > date is not testable anymore (hence adjustment in tests). > > It finally makes kcalendartest pass. > > > Diffs > ----- > > kdecore/date/kcalendarsystemqdate.cpp > f07e93b1ac87b1081cffe0702370cfe0048837c2 > kdecore/tests/kcalendartest.cpp c6077206ac7772f8356f93f680c203fa58ba06fa > > Diff: http://git.reviewboard.kde.org/r/108449/diff/ > > > Testing > ------- > > All kdelibs/frameworks unit tests pass when built against Qt5 dev. > > > Thanks, > > Kevin Ottens > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
