dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dolphinview.cpp:1222
> if (!m_selectedUrls.isEmpty()) {
> m_selectedUrls << KDirModel::simplifiedUrlList(m_selectedUrls);
> }
This line of code (from me, it turns out) is bogus, it should say `=` instead
of `<<`.
We want to replace the list with the simplified list, not concatenate the two.
And m_selectedUrls needs to contain the new URLs, just like we do when pasting.
The solution I have in mind for that is to connect to CopyJob::slotCopyingDone
and grab the "to" argument.
[discussed on IRC, but writing here for the record, and in case someone wonders
why this << gets modified]
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D29006
To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik,
pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela,
feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna,
emmanuelp, rdieter, mikesomov
