dfaure added inline comments.
INLINE COMMENTS
> dolphinview.cpp:697
> +{
> + KIO::CopyJob* job = KIO::copy(selection.urlList(), destinationPanelUrl,
> KIO::DefaultFlags);
> + KJobWidgets::setWindow(job, this);
Why is there no error handling for the copy job? It can fail too. (Try having /
as a destination...)
> dolphinview.cpp:708
> +
> + connect(job, &KIO::DropJob::result, this,
> &DolphinView::slotPasteJobResult);
> +
The slot should probably be renamed to something more generic, this isn't about
pasting anymore.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D29006
To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik,
pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela,
feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna,
emmanuelp, rdieter, mikesomov
