habacker added inline comments.
INLINE COMMENTS
> associationline.cpp:155
> */
> -int AssociationLine::count() const
> +int AssociationLine::count() const
> {
unrelated change, please omit.
> associationline.cpp:585
> +
> + case Uml::AssociationType::Coll_Message_Asynchronous:
> setStartSymbol(Symbol::None);
A tooltip is missing here
> associationline.cpp:737
> +
> case Uml::AssociationType::Coll_Message_Synchronous:
> setStartSymbol(Symbol::None);
A tooltip is missing here
> classifierwidget.cpp:1015
> const int fontHeight = fm.lineSpacing();
> -
> painter->drawRect(0, 0, 50, fontHeight);
This change also has nothing to do with this issue. While it's good to fix
empty lines or indentations, this should be done in a separate commit. This is
also true for other similar places.
> objectnodewidget.cpp:181
> {
> - if (type == QLatin1String("Central buffer"))
> + if (type == QLatin1String("Central Buffer"))
> return ObjectNodeWidget::Buffer;
This change has nothing to do with the bug this patch is intended for, so
please omit. Instead, the actual problem, namely the missing support for
translations, should be fixed. (see
https://bugs.kde.org/show_bug.cgi?id=418150) this patch is intended for.
> objectnodewidget.cpp:335
> const QStringList list = QStringList()
> - << QLatin1String("Central buffer")
> - << QLatin1String("Data store")
> + << QLatin1String("Central Buffer")
> + << QLatin1String("Data Store")
same as mentioned above
> objectnodewidget.cpp:350
> targetWidget->asObjectNodeWidget()->setObjectNodeType(type);
> - if (type == QLatin1String("Data store"))
> + if (type == QLatin1String("Data Store"))
> Dialog_Utils::askNameForWidget(targetWidget, i18n("Enter the
> name of the data store node"), i18n("Enter the name of the data store node"),
> i18n("data store name"));
dito
> portwidget.cpp:45
> {
> - setToolTip(d->name());
> + //setToolTip(d->name());
> +
Please remove this line, git log already indicates that it has been removed
> statewidget.cpp:133
> break;
> case StateWidget::Fork:
> + {
Does is a unrelated change without any change, please omit.
REPOSITORY
R139 Umbrello
REVISION DETAIL
https://phabricator.kde.org/D27584
To: jhayes, habacker, yurchor
Cc: yurchor, ltoscano, kde-doc-english, umbrello-devel, jhayes, vanderbilt
