> On Sept. 26, 2016, 4:25 p.m., Aleix Pol Gonzalez wrote: > > Again, I'll refer to how it's done in KCoreAddons. I don't think it's > > really useful to need to define variables for every framework you are > > compiling. > > Luigi Toscano wrote: > Is this last sentence part of another conversation that I missed? > > Ralf Habacker wrote: > This patch does it the same way as already implemented in kcoreaddons > https://github.com/KDE/kcoreaddons/blob/master/KF5CoreAddonsConfig.cmake.in#L11. > > Aleix Pol Gonzalez wrote: > The part I was referring to is actually: > ``` > if(CMAKE_CROSSCOMPILING AND KF5_HOST_TOOLING) > find_file(TARGETSFILE KF5CoreAddons/KF5CoreAddonsToolingTargets.cmake > PATHS ${KF5_HOST_TOOLING} ${CMAKE_CURRENT_LIST_DIR} NO_DEFAULT_PATH) > include("${TARGETSFILE}") > else() > ``` > > I don't think we should take into account CROSSCOMPILING if > KF5_HOST_TOOLING isn't specified. Including the target files should define > all the needed targets. > > Ralf Habacker wrote: > @alex: You remember that I asked about 8 month ago about an example how > to implement this way and did not get any answer ? Any now you insist to use > a broken way without any help or tutorial ? > > Aleix Pol Gonzalez wrote: > My apologies if I haven't been verbose enough. I can try to document > `KF5_HOST_TOOLING` later tonight. Would that help? > > My name is Aleix. > > Ralf Habacker wrote: > @aleix: From my experience on adding cross compile support at > https://build.opensuse.org/project/monitor/home:rhabacker:branches:windows:mingw:win32:KF526, > which is complete and works, there are several details to cover and I'm not > sure how much work remains to make it complete using the KF5_HOST_TOOLING way > after you documentated it. Because the original KDE cmake guru abandoned his > approach to implement cross compile support with KDE 4.5 and never resumes it > looks really to have some major issues. > > My suggestion is therefore to complete the recent approach (which can > coexist with the incomplete KF5_HOST_TOOLING stuff if wished) to have a > stable and working solution and then to see how to improve cross compile > support by supporting the KF5_HOST_TOOLING way. > > In short my approach compiles required native cross tools at > home:rhabacker:branches:KDE:Frameworks526 (kcoreaddons and sonnet also > includes required tools for cross compiling but related kf5 packages version > 5.26 already installs them unconditionally in the development package. (With > a few pending kf5 build system related patches reviewed this project can be > skipped). > > At > https://build.opensuse.org/project/monitor/home:rhabacker:branches:windows:mingw:win32:KF526 > all required native tools are packaged (and relocated to > /usr/bin/<cross-prefix>-<toolname>) by the mingw32-cross-kf5-tools package. > > With this and other mingw32-cross... packages provided by the opensuse > windows:mingw:win32 project, windows kf5 packages are build. The mingw32-kxx > packages fetches kf5 source packages extracted directly from kde git server > using tags and uses local patches from for fixing remaining issues (for > example > https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF526/mingw32-kdoctools). > > BTW: Sorry for using wrong name.
Whatever, what can I say? If you ask me, it looks like an ad-hoc solution to get your thing working there, but if that will bear any positive results then go for it. +0 from me. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129025/#review99539 ----------------------------------------------------------- On Sept. 26, 2016, 4:23 p.m., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129025/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 4:23 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > Enable cross compilation support for packages depending on normally installed > kdoctools tools. > > > Diffs > ----- > > KF5DocToolsConfig.cmake.in 9224fd2788aee5db4340cd0ac8115c1a06ca8ebe > > Diff: https://git.reviewboard.kde.org/r/129025/diff/ > > > Testing > ------- > > > Thanks, > > Ralf Habacker > >
