> On Sept. 26, 2016, 4:25 nachm., Aleix Pol Gonzalez wrote: > > Again, I'll refer to how it's done in KCoreAddons. I don't think it's > > really useful to need to define variables for every framework you are > > compiling. > > Luigi Toscano wrote: > Is this last sentence part of another conversation that I missed?
This patch does it the same way as already implemented in kcoreaddons https://github.com/KDE/kcoreaddons/blob/master/KF5CoreAddonsConfig.cmake.in#L11. - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129025/#review99539 ----------------------------------------------------------- On Sept. 26, 2016, 4:23 nachm., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129025/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 4:23 nachm.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > Enable cross compilation support for packages depending on normally installed > kdoctools tools. > > > Diffs > ----- > > KF5DocToolsConfig.cmake.in 9224fd2788aee5db4340cd0ac8115c1a06ca8ebe > > Diff: https://git.reviewboard.kde.org/r/129025/diff/ > > > Testing > ------- > > > Thanks, > > Ralf Habacker > >
