> On Oct. 24, 2015, 8:16 p.m., Vishesh Handa wrote: > > src/file/unindexedfileindexer.cpp, line 66 > > <https://git.reviewboard.kde.org/r/125776/diff/1/?file=412456#file412456line66> > > > > This is a silly thing, but do you think perhaps we should move this > > 'renameFilePath' call inside `replaceDocument`, and just add an extra > > operation?
Actually that's how I was initially thinking of doing it untill I stumbled upon Transaction::renameFilePath. Will update the patch. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/#review87350 ----------------------------------------------------------- On Oct. 24, 2015, 6:17 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125776/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 6:17 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Since the inode remains same on moving, the fileId should be preserved. We > can simply check if the filePath in the db is same as the actual filePath to > check if file is moved and update the filePath if needed. This will also > handle renames. > > > Diffs > ----- > > src/file/unindexedfileindexer.cpp 6873047 > > Diff: https://git.reviewboard.kde.org/r/125776/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
