> On Oct. 24, 2015, 7:11 p.m., John Layt wrote: > > src/qml/experimental/monitor.cpp, line 146 > > <https://git.reviewboard.kde.org/r/125777/diff/1/?file=412458#file412458line146> > > > > Are you sure you want the system locale? Usually you want the > > application locale by calling QLocale() instead.
So, I'm not sure how this is supposed to work. According to the documentation constructing a QLocale() object without any args gives us the defaultLocale and if none is set the system locale. So using QLocale() does make sense, but out of curiosity why would application need to override the system locale? - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/#review87348 ----------------------------------------------------------- On Oct. 24, 2015, 6:21 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125777/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 6:21 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > KFormat::spelloutDuration works perfectly well for out use case, using it is > a no brainer. > > > Diffs > ----- > > src/qml/experimental/CMakeLists.txt 0b06ac8 > src/qml/experimental/monitor.cpp dfc7037 > > Diff: https://git.reviewboard.kde.org/r/125777/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
