-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125777/#review87348
-----------------------------------------------------------



src/qml/experimental/monitor.cpp (line 146)
<https://git.reviewboard.kde.org/r/125777/#comment59982>

    Are you sure you want the system locale? Usually you want the application 
locale by calling QLocale() instead.


- John Layt


On Oct. 24, 2015, 7:21 p.m., Pinak Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125777/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 7:21 p.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> KFormat::spelloutDuration works perfectly well for out use case, using it is 
> a no brainer.
> 
> 
> Diffs
> -----
> 
>   src/qml/experimental/CMakeLists.txt 0b06ac8 
>   src/qml/experimental/monitor.cpp dfc7037 
> 
> Diff: https://git.reviewboard.kde.org/r/125777/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to