> On Sept. 2, 2015, 8:10 a.m., Kevin Funk wrote: > > src/file/timeestimator.cpp, line 46 > > <https://git.reviewboard.kde.org/r/125004/diff/3/?file=400069#file400069line46> > > > > I'm not sure this change is correct: This changes semantics wrt weights. > > > > I presume the prior approach assigned increasing weights for > > [first,last]; now it just does that for [0,end[. > > > > Double-check...
I don't see the problem you are mentioning, I use the bufferIndex variable to access the array and not 'i'. 'i' is used to keep track of which element we are at and assign weight accordingly. I might be wrong, and I probably need to write tests for this class. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/#review84740 ----------------------------------------------------------- On Sept. 2, 2015, 7:54 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125004/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 7:54 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > * Previously the m_batchTimeBuffer could be read while it was being written > to by another thread. > * Now only a single thread (the main thread) deals with m_batchTimeBuffer > avoiding the above mentioned situation. > > > Diffs > ----- > > src/file/filecontentindexer.h 186eb35 > src/file/filecontentindexer.cpp 5a504b1 > src/file/fileindexscheduler.h c30f358 > src/file/fileindexscheduler.cpp dcf45f8 > src/file/timeestimator.h 68253f9 > src/file/timeestimator.cpp b9fefcb > src/tools/baloo-monitor/monitor.cpp 4b0148e > > Diff: https://git.reviewboard.kde.org/r/125004/diff/ > > > Testing > ------- > > Querying for remaining time seems to working from baloo-monitor. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
