----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/#review84723 -----------------------------------------------------------
src/file/timeestimator.cpp (line 45) <https://git.reviewboard.kde.org/r/125004/#comment58633> No more reason to split this in two for loops, as it is guarded by m_estimateReady. Maybe put the weights into an array in a static class member. The totalWeight is also a const value now. - Stefan Brüns On Sept. 1, 2015, 11:42 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125004/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 11:42 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > * Previously the m_batchTimeBuffer could be read while it was being written > to by another thread. > * Now only a single thread (the main thread) deals with m_batchTimeBuffer > avoiding the above mentioned situation. > > > Diffs > ----- > > src/file/filecontentindexer.h 186eb35 > src/file/filecontentindexer.cpp 5a504b1 > src/file/fileindexscheduler.h c30f358 > src/file/fileindexscheduler.cpp dcf45f8 > src/file/timeestimator.h 68253f9 > src/file/timeestimator.cpp b9fefcb > src/tools/baloo-monitor/monitor.cpp 4b0148e > > Diff: https://git.reviewboard.kde.org/r/125004/diff/ > > > Testing > ------- > > Querying for remaining time seems to working from baloo-monitor. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
