> On July 28, 2014, 4:38 p.m., Vishesh Handa wrote: > > Maybe we want to declare the FileMonitor in each test, but I don't have a > > strong opinion on it. I'm fine with the patch. Nice job! > > Felix Eisele wrote: > Thanks. I have no write access to git. Can I you please push for me? I > would to get a contributer account. Could you being my supporter?
Yes definitely. You're doing a great job. PS: Here is some semi-mandatory reading. I'm sure you already know all this stuff, but still. :) * http://manifesto.kde.org/ * http://www.kde.org/code-of-conduct/ - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/#review63339 ----------------------------------------------------------- On July 26, 2014, 11:58 a.m., Felix Eisele wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119459/ > ----------------------------------------------------------- > > (Updated July 26, 2014, 11:58 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Added some Unittest for FileMonitor > > > Diffs > ----- > > src/file/autotest/filemonitortest.h 9a72813 > src/file/autotest/filemonitortest.cpp 19d8f85 > > Diff: https://git.reviewboard.kde.org/r/119459/diff/ > > > Testing > ------- > > > Thanks, > > Felix Eisele > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
