----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/#review63120 -----------------------------------------------------------
src/file/autotest/filemonitortest.h <https://git.reviewboard.kde.org/r/119459/#comment43875> Minor coding convention fix please - The private variables should come after the private slots. src/file/autotest/filemonitortest.h <https://git.reviewboard.kde.org/r/119459/#comment43869> Just out of curiosity, is there any advantage of making it a member variable instead of just initializing it in the function? src/file/autotest/filemonitortest.cpp <https://git.reviewboard.kde.org/r/119459/#comment43870> Could you please fix the coding stlye. A space before and after the = src/file/autotest/filemonitortest.cpp <https://git.reviewboard.kde.org/r/119459/#comment43871> Could you please add a space after the , src/file/autotest/filemonitortest.cpp <https://git.reviewboard.kde.org/r/119459/#comment43873> Please remove the extra space before the closing parenthesis. src/file/autotest/filemonitortest.cpp <https://git.reviewboard.kde.org/r/119459/#comment43872> If you want to make this simpler, I typically just use the QUuid class and trim the string to the appropriate length. This approach is also fine. - Vishesh Handa On July 25, 2014, 8:41 a.m., Felix Eisele wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119459/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 8:41 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Added some Unittest for FileMonitor > > > Diffs > ----- > > src/file/autotest/filemonitortest.h 9a72813 > src/file/autotest/filemonitortest.cpp 19d8f85 > > Diff: https://git.reviewboard.kde.org/r/119459/diff/ > > > Testing > ------- > > > Thanks, > > Felix Eisele > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
