Hi, On Sunday 14 August 2011 20:39:38 Chirag Anand wrote: > On Aug 14 12:07, Peter Penz wrote: > > Hello, > > > > thanks for the patch! I like the idea that the user can configure the > > start-index for renaming but (at least I) was confused with the "(000)" > > string and was not sure whether the parenthesis will get now part of the > > name. Also I was not sure whether the numbering will start with 0 or 1 (I > > only knew it after reading the code ;-)). > > > > My suggestion would be: > > - leave the # as replacement (it seemed to work well judging from the > > bug-reports) > > - Change the comment to "# will be replaced by ascending numbers starting > > with" [XXX] > > (where XXX is a KIntSpinBox-widget defaulted to 1) > > > > What do you think about this? > > Yes its a better idea indeed, removes ambiguity and leaves us with the > well-tested code. KIntSpinBox will solve our problem. And with this, the > user will be able to rename files with different extensions in a > sequence. Though right now, we don't preserve the extension while > renaming, and let the user write the extension for himself.
The extension is preserved currently but only if all selected files have the same extension. > I am > thinking that it will be really good if we can have the option of > preserving extensions and only change the first part of the files. > > My idea of extracting numbers from string was to cater to alphabets > also. Something like, if the user writes FILE-(A), then he/she should > have FILE-A, FILE-B, FILE-C, and so on. I have done this also in a > separate code but have not tried it with dolphin as yet. But yes, this > will become a little more complicated. As I was seeing it, we should be > able to do complex renaming also, like FILE-A01, FILE-A02, ... , > FILE-C04, and so on. I don't know how we should go about achieving it, > if at all its required? I'd like to keep the renaming-dialog as simple as possible in Dolphin and don't want to get a competitor to KRename (see http://www.krename.net/). Based on the bug-reports there seems to be no need for further options (at least not for the target-user group Dolphin is aiming for) so I'd say lets focus currently only to get this feature right before thinking about further things ;-) > > BTW: The general mailing-list for Dolphin and Konqueror is > > kfm-de...@kde.org, but I'd suggest to just continue the discussion here. As > > Raphael already mentioned generally it would be better to post this patch > > to https://git.reviewboard.kde.org instead (at least for future patches > > ;-)). > > Okay I have subscribed to the kfm-devel list also. I am going through > the reviewboard tutorial here: > http://techbase.kde.org/Development/Review_Board, I think I am able to > understand this. I will create the request for the current patch so that > we have the patch in record, and make the required changes based on our > discussion above. But as I see on the git URL, it needs a login which I > don't have. Do I need that? Yes, you need to subscribe once. Best regards, Peter >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
