Hello, thanks for the patch! I like the idea that the user can configure the start-index for renaming but (at least I) was confused with the "(000)" string and was not sure whether the parenthesis will get now part of the name. Also I was not sure whether the numbering will start with 0 or 1 (I only knew it after reading the code ;-)).
My suggestion would be: - leave the # as replacement (it seemed to work well judging from the bug-reports) - Change the comment to "# will be replaced by ascending numbers starting with" [XXX] (where XXX is a KIntSpinBox-widget defaulted to 1) What do you think about this? BTW: The general mailing-list for Dolphin and Konqueror is kfm-de...@kde.org, but I'd suggest to just continue the discussion here. As Raphael already mentioned generally it would be better to post this patch to https://git.reviewboard.kde.org instead (at least for future patches ;-)). Best regards, Peter On Sunday 14 August 2011 02:26:41 Chirag Anand wrote: > Hello, > > This patch applies to dolphin/src/views/renamedialog.cpp and > dolphin/src/views/renamedialog.h. It is built on the current master > branch of kde-baseapps repository. > > It replaces the current renaming functionality of Dolphin for multiple > files. The functionality gives user a little more control over how to > rename their files. It asks the user for the starting point of the > sequence of number instead of starting it always from 1. Renaming 3 > files by doing "FILE##.txt" gives us FILE01.txt, FILE02.txt, FILE03.txt. > > If we have to rename these 3 files to FILE04.txt, FILE05.txt, > FILE06.txt, we need 6 files for the operation. We cannot rename files > starting from a random number. Also, we cannot rename file with > different extensions in a sequence. Though this patch does not yet solve > this problem, what it does is to give the user a choice to start the > sequence from wherever he/she wants it to. > > I have used parenthesis '(', ')' instead of '#' as placeholder. For the > above example, we have to rename the files by doing FILE(04).txt and it > will rename the files as required. > > The patch currently does not handle enabling of button by validating > text in slotTextChanged(). It should also handle the issue of different > extensions. As this is my first patch, I wanted to confirm if I am going > in the right direction, then I can start working on the above issues > also? I do need help from the community. Suggestions and improvements in > the code, or on the idea are most welcome. > > Thanks. > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
