On Mon, Oct 31, 2016 at 4:29 PM, Albert Astals Cid <aa...@kde.org> wrote: > El divendres, 28 d’octubre de 2016, a les 18:21:48 CET, Elvis Angelaccio va > escriure: >> Hi, >> what's the status of this review? Do we want to discuss where to move this >> repo? > > Yes.
So, the repo location was playground/network. Possible destinations could be: 1. extragear/network 2. kdenetwork 3. extrager/pim 4. kdepim I would choose 3 or 4. This slave depends on libkgapi, so from a dependency point of view it makes more sense to have it in the pim module rather than the network module. Thoughts? > > Cheers, > Albert Cheers Elvis > >> >> Cheers >> Elvis >> >> On Mon, Oct 10, 2016 at 12:25 AM, Elvis Angelaccio >> >> <elvis.angelac...@kde.org> wrote: >> > On Sun, Oct 9, 2016 at 11:58 PM, Albert Astals Cid <aa...@kde.org> wrote: >> >> El dimarts, 4 d’octubre de 2016, a les 11:03:22 CEST, Elvis Angelaccio va >> >> >> >> escriure: >> >>> On Tue, Oct 4, 2016 at 10:17 AM, Ben Cooksley <bcooks...@kde.org> wrote: >> >>> > Hi all, >> >>> > >> >>> > At the request of Elvis Angelaccio sysadmin has moved kio-gdrive to >> >>> > KDE >> >>> > Review. >> >>> >> >>> Thanks Ben. >> >>> >> >>> Just a quick intro, kio-gdrive is a simple kio slave on top of >> >>> libkgapi (PIM's implementation of the Google Drive REST api). Please >> >>> have a look and, if everything looks good, let's decide where we want >> >>> to move it. >> >>> It comes from playground/network, so a possible destination would be >> >>> extragear/network or kdenetwork. But imho this could also live in the >> >>> PIM module, since it depends on libkgapi. >> >> >> >> Can you get a build.kde.org job? >> > >> > Oh right, kde-build-metadata was outdated and still looking in >> > playground. Should be fixed now. >> > >> >> Also why Qt5Keychain instead of kwallet? >> > >> > This should help deploying the slave outside of Plasma (e.g. if one >> > uses Dolphin in Gnome, it will store the gdrive secrets in the Gnome >> > keyring instead of Kwallet). On Plasma it still uses Kwallet as >> > backend. >> > >> >> I have no idea how the remote:/ kio shows its contents, but maybe would >> >> make sense to check if it allows for "plugins" and show the gdrive stuff >> >> there? Or that doesn't make sense? >> > >> > No idea either but would be nice to have indeed, I can try to have a look. >> > >> >> Cheers, >> >> >> >> Albert >> >> >> >>> > Regards, >> >>> > Ben Cooksley >> >>> > KDE Sysadmin >> >>> >> >>> Cheers >> >>> Elvis > >
