----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review34447 -----------------------------------------------------------
Ship it! Looks good to me. Maksim Orlovich suggested that we should look into using lossless WebP for images in KDE, since WebP has faster decompression than libpng, and produces smaller files. I've done some tests with Oxygen icons that confirms this. - Fredrik Höglund On June 16, 2013, 11:58 a.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110649/ > ----------------------------------------------------------- > > (Updated June 16, 2013, 11:58 a.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > This patch adds support for the new Google invented WebP image format. See > https://developers.google.com/speed/webp/?hl=ru > > This is what was submitted before in > https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to > kde-runtime > > > Diffs > ----- > > CMakeLists.txt 9f1f886 > kimgio/CMakeLists.txt PRE-CREATION > kimgio/webp.cpp PRE-CREATION > kimgio/webp.desktop PRE-CREATION > kimgio/webp.h PRE-CREATION > kimgio/webp.xml PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110649/diff/ > > > Testing > ------- > > some KDE apps, including read/write with a modified kolourpaint (to be able > to change the quality) > > > Thanks, > > Martin Koller > >
