> On May 26, 2013, 2:15 p.m., Fredrik Höglund wrote: > > kimgio/webp.cpp, line 58 > > <http://git.reviewboard.kde.org/r/110649/diff/1/?file=146351#file146351line58> > > > > This is not particularly efficient. WebPDecodeBGRAInto() can decode > > directly into a QImage without using an intermediate buffer.
As far as I understand the QImage documentation, I can not use this: "You cannot use the uchar* pointer directly, because the pixel format depends on the byte order on the underlying platform. Use qRed(), qGreen(), qBlue(), and qAlpha() to access the pixels." I understood it as: WebPDecodeRGBA() delivers always 4 consecutive bytes as RGBA, regardless of the endianess of the platform, but QImage::bits() returns a pointer to the data which contains the bytes in the order of the platform, which might be different than what WebPDecodeRGBA() delivers. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review33153 ----------------------------------------------------------- On May 26, 2013, 12:20 p.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110649/ > ----------------------------------------------------------- > > (Updated May 26, 2013, 12:20 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > This patch adds support for the new Google invented WebP image format. See > https://developers.google.com/speed/webp/?hl=ru > > This is what was submitted before in > https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to > kde-runtime > > > Diffs > ----- > > kimgio/webp.h PRE-CREATION > kimgio/webp.xml PRE-CREATION > kimgio/webp.desktop PRE-CREATION > kimgio/CMakeLists.txt PRE-CREATION > kimgio/webp.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110649/diff/ > > > Testing > ------- > > some KDE apps, including read/write with a modified kolourpaint (to be able > to change the quality) > > > Thanks, > > Martin Koller > >
