----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109421/ -----------------------------------------------------------
(Updated March 14, 2013, 3:24 p.m.) Review request for kdelibs and Jeremy Paul Whiting. Changes ------- Hey Jeremy, cool, thanks. The patch I proposed doesn't do that, it just adds the provider file to the default files. I agree though that the better behavior would be only to show the new file then. Since I'm not entirely sure if I did that correctly, I'll update the patch once more -- if you don't see a problem with it, should I just push it to kdelibs master? Cheers, Sven Description ------- The download dialog correctly takes a custom providers .xml file, as can be specified in the .knsrc file, into account; however the upload dialog just ignored this option until now. This patch intends to fix that behavior. Nothing should change if you don't have a custom ProvidersUrl= in your .knsrc file. Diffs (updated) ----- knewstuff/knewstuff3/upload/atticahelper.h 4e538d3 knewstuff/knewstuff3/upload/atticahelper.cpp 735910f knewstuff/knewstuff3/uploaddialog.cpp 70a8568 knewstuff/knewstuff3/uploaddialog_p.h 50f8dd9 Diff: http://git.reviewboard.kde.org/r/109421/diff/ Testing ------- The new provider is correctly being listed in the dropdown list of the first page of the dialog. If the custom provider is selected, the program tries to establish a connection to that provider. However, I could not test it any further because I don't have a working provider server... yet. File Attachments ---------------- a screenshot of the dialog showing two providers, one of them loaded from the XML file specified in .knsrc http://git.reviewboard.kde.org/media/uploaded/files/2013/03/11/newdialog1.png Thanks, Sven Brauch
