----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109421/#review29158 -----------------------------------------------------------
One thing which came to my mind while I further worked on this, should the custom providers be added to the list, or replace it? I.e., if I have custom providers listed, should the default ones still be displayed or not? - Sven Brauch On March 11, 2013, 11:34 p.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109421/ > ----------------------------------------------------------- > > (Updated March 11, 2013, 11:34 p.m.) > > > Review request for kdelibs and Jeremy Paul Whiting. > > > Description > ------- > > The download dialog correctly takes a custom providers .xml file, > as can be specified in the .knsrc file, into account; however the > upload dialog just ignored this option until now. This patch > intends to fix that behavior. > Nothing should change if you don't have a custom ProvidersUrl= in your > .knsrc file. > > > Diffs > ----- > > knewstuff/knewstuff3/upload/atticahelper.h 4e538d3 > knewstuff/knewstuff3/upload/atticahelper.cpp 735910f > knewstuff/knewstuff3/uploaddialog.cpp 70a8568 > knewstuff/knewstuff3/uploaddialog_p.h 50f8dd9 > > Diff: http://git.reviewboard.kde.org/r/109421/diff/ > > > Testing > ------- > > The new provider is correctly being listed in the dropdown list of the first > page of the dialog. If the custom provider is selected, the program tries to > establish a connection to that provider. However, I could not test it any > further because I don't have a working provider server... yet. > > > File Attachments > ---------------- > > a screenshot of the dialog showing two providers, one of them loaded from the > XML file specified in .knsrc > > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/11/newdialog1.png > > > Thanks, > > Sven Brauch > >
