----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23730 -----------------------------------------------------------
Thanks for this - I was just trying to figure out why the konsole .icns wasn't copied to the Resources folder. The patch does work for Konsole in generating the .icns and installing it. I do get warnings for some .png that it couldn't create. If there is concern about the icon/png creation, perhaps split the patches into 2. I'd like to see the fix for the .icns Resources to go in asap and backported. I tested this on my mac mini ML w/ macports - konsole from master trunk. - Kurt Hindenburg On Dec. 16, 2012, 7:26 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107752/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2012, 7:26 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > There are two issues when using kde4_add_app_icon on mac. a) apps using > kdeinit won't install icon files to thier app bundles, b) mac app icon > generating method is outdated and does not support retina resolution. > > The patch changed kde4_add_kdeinit_executable and kde4_add_app_icon to solve > these issues. > > > Diffs > ----- > > cmake/modules/KDE4Macros.cmake 0753879 > > Diff: http://git.reviewboard.kde.org/r/107752/diff/ > > > Testing > ------- > > Works well on 4.9 branch. > Not sure if some changes breaks other platforms. > > > Thanks, > > Yue Liu > >
