https://bugs.kde.org/show_bug.cgi?id=481492

Ismael Asensio <isma...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi
                   |t/7e7c042a93d294cf79ee440ac |t/c8cd82cc860e8c9fc462c9155
                   |16383495e5b7294             |604d7d8fa12bdb7
   Version Fixed In|                            |6.2
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Ismael Asensio <isma...@gmail.com> ---
Git commit c8cd82cc860e8c9fc462c9155604d7d8fa12bdb7 by Ismael Asensio.
Committed on 25/08/2024 at 23:22.
Pushed by iasensio into branch 'master'.

dataengines/weather: Fix stalled data on weather updates

Due to the weather's ion and the DataEngine's infrastructure it was
not possible to remove outdated keys from the data, which resulted
in the applet showing stalled info that were no longer relevant, like
"wind gust" or the "feels like" indices.

The root cause is double:

- A dataengine's `setData()` will not remove keys that are no longer
  present in the new data, so we need to force removing them manually
  via `removeData()` or `removeAllData()`

- There are two concurrent dataengines involved:
  - The master `weather` engine which the applet is connected to and
    serves as a general interface
  - An internal `ion` engine loaded by the master which does the
    actual weather job

To fix the issue let's provide a signal for the ions to request
cleaning up the data on the master engine, and call it before setting
the new weather updates.
FIXED-IN: 6.2

M  +1    -0    dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
M  +1    -0    dataengines/weather/ions/dwd/ion_dwd.cpp
M  +2    -0    dataengines/weather/ions/envcan/ion_envcan.cpp
M  +1    -0    dataengines/weather/ions/ion.cpp
M  +4    -0    dataengines/weather/ions/ion.h
M  +2    -1    dataengines/weather/ions/noaa/ion_noaa.cpp
M  +1    -0    dataengines/weather/ions/wetter.com/ion_wettercom.cpp
M  +4    -0    dataengines/weather/weatherengine.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/c8cd82cc860e8c9fc462c9155604d7d8fa12bdb7

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to