https://bugs.kde.org/show_bug.cgi?id=487905

Jack Hill <jackhill3...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult
                   |imedia/elisa/-/commit/d8bd1 |imedia/elisa/-/commit/ec8ae
                   |a35a835d44d28a07e7e671e7cfc |492467320e6cb09b88167d22049
                   |29d07073                    |3dba9479

--- Comment #15 from Jack Hill <jackhill3...@gmail.com> ---
Git commit ec8ae492467320e6cb09b88167d220493dba9479 by Jack Hill.
Committed on 08/06/2024 at 11:10.
Pushed by ngraham into branch 'release/24.05'.

Fix DBus service activation

Previously this was supposed to be started in ElisaApplication::create,
except it wasn't started because this function was never called.

https://doc.qt.io/qt-6/qqmlengine.html#QML_SINGLETON

> By default, each QQmlEngine will try to create a singleton instance
> using either the type's default constructor or a static factory
> function of the signature T *create(QQmlEngine *, QJSEngine *) when
> the type is first accessed. If both do exist and are accessible, the
> default constructor is preferred.

Test-plan:
Run kdesrc-build --run elisa. After the window is launched, run the same
command in a separate terminal session.

Before: two instances of Elisa opened

Now: only one instance of Elisa opens.

Amends fc374017

(cherry picked from commit d8bd1a35a835d44d28a07e7e671e7cfc29d07073)

M  +0    -23   src/elisaapplication.cpp
M  +0    -2    src/elisaapplication.h
M  +15   -1    src/main.cpp

https://invent.kde.org/multimedia/elisa/-/commit/ec8ae492467320e6cb09b88167d220493dba9479

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to