https://bugs.kde.org/show_bug.cgi?id=481874
Mark Wielaard <m...@klomp.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m...@klomp.org
--- Comment #9 from Mark Wielaard <m...@klomp.org> ---
This is such a huge patch that I don't really know where to start.
Can this be split up a little?
Maybe have the changes needed to compile with clang instead of gcc separate
from the rest? Or does freebsd arm64 only support building with clang?
Likewise maybe separate the VEX/corgrind stuff from the tools and the tests?
I randomly looked at the sbrk changes for the testcases. Which seems necessary
because freebsd doesn't have sbrk on arm64 or riscv. That configure check and
disabling of dw4 and pages_as_heap seem fine.
In VEX. What are the priv/guest_arm64_toIR.c changes for?
You need LibVEX_GuestARM64_put_nzcv_c to signal syscall success/failure.
I am not fully clear what the guest_SETC is for. The guest_SC_CLASS seems to be
to determine how syscall numbers are passed.
Would it make sense to only include those fields, and padding, for freebsd?
--
You are receiving this mail because:
You are watching all bug changes.
