https://bugs.kde.org/show_bug.cgi?id=481874

--- Comment #17 from Mark Wielaard <m...@klomp.org> ---
.git-blame-ignore-revs references a clang-format rev that doesn't exist in
tree.

Makefile.all.am and Makefile.tool.am look correct.

NEWS OK.

VEX changes OK, except for unnecessarily extending VexGuestARM64State for
non-freebsd systems.
Would be really nice if that VEX/auxprogs/genoffsets.c
GENOFFSET(ARM64,arm64,SETC); could only
be done of freebsd. 

configure.ac looks OK (but not a fan of the reindentations, it makes looking
for the actual changes a bit of a pain)

coregrind/launcher-freebsd.c OK

coregrind/m_aspacemgr changes OK (aspacemgr-linux.c is clearly a bad name, but
lets not rename it for now).

coregrind/m_coredump/coredump-elf.c looks correct (do we have any tests for
this? I don't believe we do).

coregrind/m_debuginfo changes look OK.

coregrind/m_debuglog.c dunno why there is a clang and gcc variant of
local_sys_write_stderr. One uses SizeT the other Unt (should be Int).

coregrind/m_dispatch/dispatch-arm64-freebsd.S Not sure I am qualified to review
this voodoo.

coregrind/m_initimg/initimg-freebsd.c looks OK

coregrind/m_libcassert.c, coregrind/m_libcfile.c, coregrind/m_libcsetjmp.c OK

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to