https://bugs.kde.org/show_bug.cgi?id=470084
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/grap
| |hics/krita/-/commit/205731b
| |2aa5ab530cbd145cb32dac4796b
| |ac23a3
--- Comment #4 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 205731b2aa5ab530cbd145cb32dac4796bac23a3 by Dmitry Kazakov.
Committed on 16/06/2023 at 15:30.
Pushed by dkazakov into branch 'master'.
Fix loading PSD files with Input-class ICC profiles
We cannot use such color space for work, hence we should convert
the space into something usable on loading. The patch implements
the code that asks the user about the preferred space and then
just converts into that.
Since it is impossible to convert any color **into** this color space
the patch also implements the following:
1) All delayed-update nodes are now guaranteed not to start any
regeneration while the image is locked. This way their job will
**not** come before the conversion stroke.
2) There is not KoColor::createTransparent(cs) call used by the merging
code for setting the backdrop color. Previously it used the conversion
from QColor (sRGB), which is impossible for obvious reasons.
3) When loading a generator layer from PSD we now convert the fill-color
into LabA-32f, if the color's color space is not appropriate. The point
of this step: we don't convert filter's color on image color space
conversion.
4) The patch also implements KisImportUserFeedbackInterface to ask the
used about the decision. It is necessary to allow import-export manager
to use asynchonous loading in the future.
M +4 -4 libs/image/KisEncloseAndFillPainter.cpp
M +1 -1 libs/image/floodfill/kis_scanline_fill.cpp
M +10 -0 libs/image/generator/kis_generator_layer.cpp
M +2 -2 libs/image/kis_image.cc
M +1 -0 libs/image/kis_image_barrier_lock_adapter.h
M +2 -3 libs/image/kis_paint_device.cc
M +1 -1 libs/image/kis_pixel_selection.cpp
M +11 -0 libs/image/kis_transform_mask.cpp
M +1 -1 libs/image/kis_transparency_mask.cc
M +1 -1 libs/image/lazybrush/kis_colorize_mask.cpp
M +1 -1 libs/image/lazybrush/kis_colorize_stroke_strategy.cpp
M +9 -0
libs/image/processing/kis_convert_color_space_processing_visitor.cpp
M +1 -0
libs/image/processing/kis_convert_color_space_processing_visitor.h
M +0 -1 libs/image/tests/kis_layer_style_projection_plane_test.cpp
M +11 -0 libs/pigment/KoColor.cpp
M +8 -0 libs/pigment/KoColor.h
M +6 -0 libs/pigment/KoColorSpace.cpp
M +8 -0 libs/pigment/KoColorSpace.h
M +11 -0 libs/psd/psd_additional_layer_info_block.h
M +3 -0 libs/ui/CMakeLists.txt
M +10 -0 libs/ui/KisImportExportFilter.cpp
M +3 -0 libs/ui/KisImportExportFilter.h
M +32 -0 libs/ui/KisImportExportManager.cpp
M +79 -0 libs/ui/KisImportExportUtils.cpp
M +20 -0 libs/ui/KisImportExportUtils.h
A +8 -0 libs/ui/KisImportUserFeedbackInterface.cpp [License:
GPL(v2.0+)]
A +47 -0 libs/ui/KisImportUserFeedbackInterface.h [License:
GPL(v2.0+)]
M +2 -2 libs/ui/actions/kis_selection_action_factories.cpp
R +23 -0 libs/ui/dialogs/dlg_colorspaceconversion.cc [from:
plugins/extensions/colorspaceconversion/dlg_colorspaceconversion.cc - 078%
similarity]
R +10 -2 libs/ui/dialogs/dlg_colorspaceconversion.h [from:
plugins/extensions/colorspaceconversion/dlg_colorspaceconversion.h - 071%
similarity]
M +10 -0 libs/ui/flake/kis_shape_layer_canvas.cpp
M +1 -1 libs/ui/flake/kis_shape_selection.cpp
R +0 -0 libs/ui/forms/wdgconvertcolorspace.ui [from:
plugins/extensions/colorspaceconversion/wdgconvertcolorspace.ui - 100%
similarity]
M +1 -1 libs/ui/tool/kis_tool_utils.cpp
M +1 -1
plugins/dockers/advancedcolorselector/kis_color_selector_simple.cpp
M +1 -1
plugins/dockers/advancedcolorselector/kis_color_selector_triangle.cpp
M +1 -1
plugins/dockers/advancedcolorselector/kis_color_selector_wheel.cpp
M +1 -2 plugins/extensions/colorspaceconversion/CMakeLists.txt
M +5 -6 plugins/extensions/colorspaceconversion/colorspaceconversion.cc
M +2 -2 plugins/impex/libkra/kis_kra_load_visitor.cpp
M +1 -1 plugins/impex/psd/psd_import.cc
M +9 -3 plugins/impex/psd/psd_loader.cpp
M +3 -1 plugins/impex/psd/psd_loader.h
M +1 -1 plugins/paintops/mypaint/MyPaintSurface.cpp
https://invent.kde.org/graphics/krita/-/commit/205731b2aa5ab530cbd145cb32dac4796bac23a3
--
You are receiving this mail because:
You are watching all bug changes.
