https://bugs.kde.org/show_bug.cgi?id=457504
Feiyang Chen <chenfeiy...@loongson.cn> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chenfeiy...@loongson.cn
--- Comment #5 from Feiyang Chen <chenfeiy...@loongson.cn> ---
(In reply to Paul Floyd from comment #4)
> With a build based on 45c61d598f435d59302dea084912cd3390de1ffc
>
> There was 1 merge rejection:
> ./helgrind/tests/Makefile.am.rej
> due to an extra filter I added
>
Thank you for your review!
I will remove the changes and extra test for helgrind tls_threads.
> I get a few warnings
>
> priv/guest_loongarch64_toIR.c:354:23: warning: unused function 'mkU16'
> [-Wunused-function]
> 1 warning generated.
> priv/guest_loongarch64_helpers.c:470:26: warning: shift count >= width of
> type [-Wshift-count-overflow]
> 1 warning generated.
> priv/guest_loongarch64_toIR.c:354:23: warning: unused function 'mkU16'
> [-Wunused-function]
> 1 warning generated.
I will fix these build warnings.
> You need to cleanup the new Makefile.am files
>
> memcheck/tests/loongarch64-linux/Makefile.am:1: error:
> scalar.stderr.exp.orig is missing in EXTRA_DIST
> memcheck/tests/loongarch64-linux/Makefile.am:1: error: filter_stderr.orig is
> missing in dist_noinst_SCRIPTS
> memcheck/tests/Makefile.am:1: error: leak-segv-jmp.stderr.exp.orig is
> missing in EXTRA_DIST
> helgrind/tests/Makefile.am:1: error: tls_threads_tunable.stderr.exp is
> missing in EXTRA_DIST
> helgrind/tests/Makefile.am:1: error: tls_threads_tunable.stderr.exp.orig is
> missing in EXTRA_DIST
> helgrind/tests/Makefile.am:1: error: tls_threads_tunable.vgtest is missing
> in EXTRA_DIST
> massif/tests/Makefile.am:1: error: big-alloc.post.exp-loongarch64.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: atomic.stdout.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: branch.stdout.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: cpucfg.stdout.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: fault.stderr.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: fault.stdout.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: fault_fp.stderr.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: fault_fp.stdout.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: float.stdout.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: integer.stdout.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: llsc.stdout.exp.orig is missing
> in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: memory.stdout.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: move.stdout.exp.orig is missing
> in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: pc.stdout.exp.orig is missing
> in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: special.stdout.exp.orig is
> missing in EXTRA_DIST
> none/tests/loongarch64/Makefile.am:1: error: filter_stderr.orig is missing
> in dist_noinst_SCRIPTS
> none/tests/loongarch64/Makefile.am:1: error: atomic.stderr.exp is in
> EXTRA_DIST but doesn't exist
> none/tests/loongarch64/Makefile.am:1: error: branch.stderr.exp is in
> EXTRA_DIST but doesn't exist
> none/tests/loongarch64/Makefile.am:1: error: cpucfg.stderr.exp is in
> EXTRA_DIST but doesn't exist
> none/tests/loongarch64/Makefile.am:1: error: float.stderr.exp is in
> EXTRA_DIST but doesn't exist
> none/tests/loongarch64/Makefile.am:1: error: integer.stderr.exp is in
> EXTRA_DIST but doesn't exist
> none/tests/loongarch64/Makefile.am:1: error: llsc.stderr.exp is in
> EXTRA_DIST but doesn't exist
> none/tests/loongarch64/Makefile.am:1: error: memory.stderr.exp is in
> EXTRA_DIST but doesn't exist
> none/tests/loongarch64/Makefile.am:1: error: move.stderr.exp is in
> EXTRA_DIST but doesn't exist
> none/tests/loongarch64/Makefile.am:1: error: pc.stderr.exp is in EXTRA_DIST
> but doesn't exist
> none/tests/loongarch64/Makefile.am:1: error: special.stderr.exp is in
> EXTRA_DIST but doesn't exist
>
I ran make regtest on both amd64-linux and loongarch64-linux, but neither of
them reported the makefile consistency error. So I don't know how these errors
are generated. Could you help me?
> I don't think that the changes and extra test for helgrind tls_threads are
> still necessary.
>
I will remove them.
> I get one regtest failure.
>
> none/tests/libvexmultiarch_test 1 0 0
>
> Gives me
> vex: priv/host_loongarch64_isel.c:2659 (void iselNext(ISelEnv *, IRExpr *,
> IRJumpKind, Int)): Assertion `0' failed.
> //// failure exit called by libVEX
>
It seems that I need to add Ijk_Call and Ijk_Ret support for loongarch64.
> I had a quick lock at the modified code, looks OK to me.
>
> I haven't looked at the added files yet.
--
You are receiving this mail because:
You are watching all bug changes.
