https://bugs.kde.org/show_bug.cgi?id=448114
Ahmad Samir <a.samir...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Version Fixed In| |22.04.3
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/netw
| |ork/kio-extras/commit/f60b3
| |27c5ab3a48b1eb781a67e553f33
| |f2ced71a
--- Comment #5 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit f60b327c5ab3a48b1eb781a67e553f33f2ced71a by Ahmad Samir.
Committed on 13/06/2022 at 19:20.
Pushed by ahmadsamir into branch 'master'.
kio_filenamesearch: don't use iterators when searching pending dirs
Looking at the backtrace from the bug report, it looks like the vector
could get reallocated when it changes capacity ...etc, which would
invalidate iterators.
Instead use a FIFO std::queue, since ideally the dirs should be searched in
the same order they're added to the pendingDirs container, and then
removed, and removing from the from of a vector is more costly than with a
queue (which uses a std::deque by default).
FIXED-IN: 22.04.3
M +6 -6 filenamesearch/kio_filenamesearch.cpp
M +2 -2 filenamesearch/kio_filenamesearch.h
https://invent.kde.org/network/kio-extras/commit/f60b327c5ab3a48b1eb781a67e553f33f2ced71a
--
You are receiving this mail because:
You are watching all bug changes.
