https://bugs.kde.org/show_bug.cgi?id=452139
Ahmad Samir <a.samir...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/fram
| |eworks/kio/commit/4b0b91d39
| |d8a4f7f0f044f3589b5c7de6710
| |44c1
Version Fixed In| |5.94
--- Comment #12 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit 4b0b91d39d8a4f7f0f044f3589b5c7de671044c1 by Ahmad Samir.
Committed on 06/05/2022 at 17:51.
Pushed by ahmadsamir into branch 'master'.
KFileWidget: allow icon sizes to go up to 512
Nowadays monitors are getting bigger, and resolutions are getting higher,
so bigger icon sizes make sense for the bigger image previews use-case.
Change the icons slider to only allow standard icon sizes:
- with the range being 16-512, the slider handling code would be much more
complicated to be usable (would have to use a logarithmic scale)
- icons look best when at a standard size (otherwise scaling is involved
and they don't look as good)
- this is the "open file dialog", typically one would use this dialog for
less than 1 minute, to open/save a file, so the fine-grained icon size
control isn't needed, and 16, 22, 32, 48...etc pretty much cover a wide
range already.
This is going back to not having 1:1 (1px icon size == 1 step on the slider)
scale on the slider, but instead of having the logic to handle that in
KDirOperator, I left KDirOperator as-is using setIconSize(actual-icon-
size), and instead implemented the logic in KFileWidget by tweaking the
slider handling code, I think it's simpler that way.
Also use the new enum values from KIconLoader::StdSizes.
FIXED-IN: 5.94
M +3 -2 src/filewidgets/kdiroperator.cpp
M +51 -59 src/filewidgets/kfilewidget.cpp
https://invent.kde.org/frameworks/kio/commit/4b0b91d39d8a4f7f0f044f3589b5c7de671044c1
--
You are receiving this mail because:
You are watching all bug changes.
