https://bugs.kde.org/show_bug.cgi?id=360478

--- Comment #231 from Bharadwaj Raju <bharadwaj.raju...@protonmail.com> ---
(In reply to tomashnyk from comment #230)
> If the patch solves the issue at least partially, would it not make sense to
> merge the patch as is? I started to test the patch and icons stay when I
> replug and unplug monitors or change the resolution of my screen. I f I read
> the history from October 2021 correctly, it mostly works for other people
> too.

Correct, the patch solves the issue for most people. And it does solve the
issue for Nick too, except on his machine it also introduces a new bug. I guess
it could be merged, but I'm wary since it has this rare but known bug which
actually makes the problem worse than before, not just status quo. If the bug
was simply that it didn't solve the issue for some people while not making it
*worse* for them, I would have much less problems with merging it. Right now
only a few people have tested it and we found this issue, with a full release
it might affect many more.

> I can see in the merge request a cpp file was also changed:
> https://invent.kde.org/plasma/plasma-desktop/-/blob/
> c06d7b0628cc31c1cd4b9d98f2ceb407c1741486/containments/desktop/package/
> contents/ui/FolderView.qml
> 
> that does not need recompiling?

That does need recompiling, aside from the QML files.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to