https://bugs.kde.org/show_bug.cgi?id=439090
Mark Wielaard <m...@klomp.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|REPORTED |CONFIRMED
CC| |m...@klomp.org
--- Comment #5 from Mark Wielaard <m...@klomp.org> ---
(In reply to Lubomir Rintel from comment #4)
> Created attachment 142144 [details]
> Add close_range(2) support
>
> Here's my take at implementing close_range(2) support. Hope it's useful.
Thanks. This looks near perfect.
I kept the FUSE_COMPATIBLE_MAY_BLOCK since we have added that for other modern
file syscalls too (e.g. statx)
At first I thought we needed to use ML_(fd_allowed), but that would croak in
some casses we don't really want here. So the manual checks here are good.
last should be unsigned too, otherwise the comparisons don't work if ARG2 ==
-1.
In the POST handler we should do the same limiting as in the the PRE handler or
we'll keep calling record_closed_fd forever when running with --trace-fds=yes
and someone does a close_range (3, -1).
Also, we shouldn't record the fds as closed when the CLOSE_RANGE_CLOEXEC flag
is set.
I have changes for the above. Will post tomorrow.
--
You are receiving this mail because:
You are watching all bug changes.
