https://bugs.kde.org/show_bug.cgi?id=405649

--- Comment #5 from Harald Sitter <sit...@kde.org> ---
(In reply to Ahmad Samir from comment #3)
> https://invent.kde.org/frameworks/kguiaddons/-/merge_requests/18
> 
> This url help:/kinfocenter/index.html#kcm_memory doesn't really exist, I
> think it works because khelpcenter indexes all the html files in the
> handbook cache tarball (brief skimming of its code and looking at debug
> output, so not 100% sure), however when falling back to opening
> docs.kde.org, that indexing isn't an option, so the url has to be more
> precise.
> 
> Both of these work with khelpcenter:
> help:/kinfocenter/index.html#kcm_memory
> help:/kinfocenter/kcm_memory.html
> 
> I would argue that that second url is more accurate, as it points to an
> actual html file (whether it's one generated from the docbook cache.bz2 on
> the user's disk or it's the html file on docs.kde.org). That will probably
> require a mass change in .desktop files with X-DocPath.
> 
> The code in KGuiAddons should now handle both cases i.e. if it gets
> help:/foo/index.html#bar it'll use:
> foo/bar.html

For the url thrown at the browser? This sounds wrong.

#foo is referring to an anchor on the page, not a page.

e.g.
https://docs.kde.org/stable5/en/kinfocenter/kinfocenter/module.html#aboutsystem

which is

<a name="aboutsystem"></a>

When the X-DocPath is `kinfocenter/module.html#aboutsystem` it actually really
needs to open
https://docs.kde.org/stable5/en/kinfocenter/kinfocenter/module.html#aboutsystem

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to