https://bugs.kde.org/show_bug.cgi?id=405649

Ahmad Samir <a.samir...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.samir...@gmail.com
     Ever confirmed|0                           |1
             Status|REPORTED                    |ASSIGNED

--- Comment #3 from Ahmad Samir <a.samir...@gmail.com> ---
https://invent.kde.org/frameworks/kguiaddons/-/merge_requests/18

This url help:/kinfocenter/index.html#kcm_memory doesn't really exist, I think
it works because khelpcenter indexes all the html files in the handbook cache
tarball (brief skimming of its code and looking at debug output, so not 100%
sure), however when falling back to opening docs.kde.org, that indexing isn't
an option, so the url has to be more precise.

Both of these work with khelpcenter:
help:/kinfocenter/index.html#kcm_memory
help:/kinfocenter/kcm_memory.html

I would argue that that second url is more accurate, as it points to an actual
html file (whether it's one generated from the docbook cache.bz2 on the user's
disk or it's the html file on docs.kde.org). That will probably require a mass
change in .desktop files with X-DocPath.

The code in KGuiAddons should now handle both cases i.e. if it gets
help:/foo/index.html#bar it'll use:
foo/bar.html

However if we get help:/okular/index.html#adding_digital_signatures that won't
work (see bug 438205), that should be fixed with
https://invent.kde.org/graphics/okular/-/merge_requests/441 which basically
changes the url to:
help:/okular/signatures.html#adding_digital_signatures

and now the openHelp() method can handle it.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to