https://bugs.kde.org/show_bug.cgi?id=362329
--- Comment #7 from Julian Seward <jsew...@acm.org> --- (In reply to Carl Love from comment #6) > [..] My preference would be to just pass the size > of the expr to be created and then just setup the IROp's in the function. I > think it is cleaner to the reader and a bit less error prone. Let the > function make sure it generates 64 bit or 32 bit iops rather then the user > messing up on one of the arguments. Yes, this all seems fine. Thanks for doing the fixups. > I wasn't aware of the the issue with the back end generating code multiple > times. So basically the rule of thumb should be: If you use a computed > value multiple times, compute it into a temp not an expression. Yes, exactly. Temps are always safe for multiple-use since they really just become registers in the back end code generator. Looks good to land. -- You are receiving this mail because: You are watching all bug changes.
