https://bugs.kde.org/show_bug.cgi?id=416695
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.18.1
Latest Commit| |https://commits.kde.org/pla
| |sma-desktop/7a48de1efa224e6
| |16d9f24f1fa1e4cdab0bce196
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 7a48de1efa224e616d9f24f1fa1e4cdab0bce196 by David Edmundson.
Committed on 14/02/2020 at 12:17.
Pushed by davidedmundson into branch 'Plasma/5.18'.
Set toolbox to invisble when it's hidden
Summary:
opacity was bound to editMode, but this did not affect visibility or
enabled.
Not only is this somewhat wasteful, enabled is very important as
otherwise shortcuts for buttons get intercepted to match the accelerator
applied to the internal buttons. This breaks all the multi-key shortcuts
that plasma uses as alt+d gets taken.
FIXED-IN: 5.18.1
Test Plan:
Mad gammaray skillz to find the bug
Checked alt+d, a now opens the widget explorer
Checked edit mode through the context menu still showed the toolbox
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27386
M +1 -0 toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
M +0 -2 toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
https://commits.kde.org/plasma-desktop/7a48de1efa224e616d9f24f1fa1e4cdab0bce196
--
You are receiving this mail because:
You are watching all bug changes.
