https://bugs.kde.org/show_bug.cgi?id=413181
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kwi
| |dgetsaddons/969ec7f2e964ddb
| |5f2aaa6a70e2d272cf21e9202
Version Fixed In| |5.65
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #7 from Nate Graham <n...@kde.org> ---
Git commit 969ec7f2e964ddb5f2aaa6a70e2d272cf21e9202 by Nate Graham.
Committed on 29/11/2019 at 14:26.
Pushed by ngraham into branch 'master'.
Unify KPageDialog margin handling into KPageDialog itself
Summary:
This prevents us from having to manually specify the margins in all of the
subclasses.
FIXED-IN: 5.65
Test Plan:
Assistant dialog now has correct margins: {F7777208}
App settings window still has correct margins: {F7777746}
After applying D25451, Multi-KCM KCMShell dialog still has correct margins:
{F7777747}
After applying D25451, single-KCM KCMShell dialog still has correct margins:
{F7777748}
Please test extensively; this code seems somewhat fragile.
Reviewers: #frameworks, cfeck, mart
Reviewed By: mart
Subscribers: kossebau, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D25444
M +15 -5 src/kpagedialog.cpp
M +0 -1 src/kpageview.cpp
M +0 -5 src/kpagewidget.cpp
https://commits.kde.org/kwidgetsaddons/969ec7f2e964ddb5f2aaa6a70e2d272cf21e9202
--
You are receiving this mail because:
You are watching all bug changes.
